On 2 Aug 2017, at 09:58, Linus Nordberg linus@sunet.se wrote:
Ralf Hildebrandt Ralf.Hildebrandt@charite.de wrote Tue, 1 Aug 2017 15:34:16 +0200:
Ralf is currently running with a patch that fixes this by taking a separate mutex before increasing or decreasing the reference count for a realm.
No crashes so far; I'd say we need to give this 2 more working days, but it sure seem to be crashing less than before (which was about 4 times a day)
No crashes today, either.
Thanks for the update. I think it's time for radsecproxy-1.6.9.
Two things regarding this bug though.
Why didn't we hear from this until now?
Good question.
The offending code is far from new. Who else besides Ralf run radsecproxy in a static configuration (ie no dynamicLookupCommand) on a multicore system and handle at least 10 requests/second?
In Germany most of the eduroam federation members using radsecproxy already. So I’m very surprised that there is no information about so many crashes.
And we have a deadline on 2017, Dec. 1 in order to move all German eduroam federation members to RadSec standard protocol, radsecproxy or RADIATOR.
Finally, I’m very happy that you both found this bug and it would be grateful if you can release 1.6.9 soon, best before the deadline. :-)
Would you mind grepping your logs for signs of crashes? 'createlistener' might be a good string to grep for.
I’ll forward your email to the Germany eduroam list, hopefully to find out more.
I'm assuming that _reading_ a uint32_t without protection is going to be safe on all architectures we care about. Let me know if you think this is not true. _______________________________________________ radsecproxy mailing list radsecproxy@lists.nordu.net https://lists.nordu.net/listinfo/radsecproxy
Best regards Ralf
-- Verein zur Förderung eines Deutschen Forschungsnetzes e.V. Alexanderplatz 1, D - 10178 Berlin Tel.: 030 88 42 99 23 Fax: 030 88 42 99 70 http://www.dfn.de http://www.dfn.de/
Vorstand: Prof. Dr. Hans-Joachim Bungartz (Vorsitzender), Dr. Ulrike Gutheil, Dr. Rainer Bockholt Geschäftsführung: Dr. Christian Grimm, Jochem Pattloch